search

experience-experiments / react-easy-chart

[DEPRECATED] - Easy to use React Charting library
http://experience-experiments.github.io/react-easy-chart
BSD 3-Clause "New" or "Revised" License
142 stars 55 forks source link

changed className prop from false to empty string #111

Closed martinkomitsky closed 6 years ago

martinkomitsky commented 6 years ago

className prop can't be type of Boolean. This thing caused an according error before. image

martinkomitsky commented 6 years ago

@petermason can you please review this?

petermason commented 6 years ago

@martinkomitsky prefer null to undefined.

martinkomitsky commented 6 years ago

@petermason y? See the error above? Null is not the right way to disable any props

petermason commented 6 years ago

@martinkomitsky i see. should the alternative simple be an empty string?

martinkomitsky commented 6 years ago

@petermason sure, that would work.

petermason commented 6 years ago

@sat- can you look at this for @martinkomitsky. I am no longer authorised to merged pull requests.

petermason commented 6 years ago

@harunhasdal ^^

martinkomitsky commented 6 years ago

@harunhasdal Super! Can we publish this to npm? 👍

harunhasdal commented 6 years ago

Published in 0.1.14.