search

experiment322 / controlloid-client

Android app which turns your phone into a game controller.
GNU General Public License v3.0
103 stars 11 forks source link

Crash on entering the layout editor after upgrading to v1.2.0 #10

Closed githubtefo closed 4 years ago

githubtefo commented 4 years ago

Hi! I've been using Controlloid on my Lineage OS mido. But since the last update downloaded from F-droid, the App crashes every time I open the a layout to edit/create it.

experiment322 commented 4 years ago

Even if you create a new layout and try to edit it? Or does this happen only on existing layouts?

githubtefo commented 4 years ago

It happens on both, new and old layouts.

hpmc13 commented 4 years ago

I'm seeing the same result as well. Existing layouts, new layouts, even if I change the theme. Thanks for looking into this. I really like this app.

githubtefo commented 4 years ago

Thanks for looking into this. I really like this app.

Me too! I really appreciate it.

experiment322 commented 4 years ago

I think I've found the culprit and it's because of the way I store the current theme (💀bad architectural decisions 💀). The issue only appears when you've upgraded the app from a previous version to v1.2.0. It doesn't happen on a clean install.

So, a quick fix for you guys would be to reset the preferences, thus resetting the theme and then you can set them back as they were.

I'll try to release a new version these days to fix the issue.

hpmc13 commented 4 years ago

Thank You! Resetting worked perfectly.

githubtefo commented 4 years ago

Thank you! It's working here too! and I can clearly notice that the dark theme switch from grey to dark.