search

experimental-design / bofire

Experimental design and (multi-objective) bayesian optimization.
https://experimental-design.github.io/bofire/
BSD 3-Clause "New" or "Revised" License
188 stars 22 forks source link

DoE: Fix bug if fixed_experiments contain columns that are not in domain #321

Closed dlinzner-bcs closed 8 months ago

dlinzner-bcs commented 8 months ago

from here: https://github.com/experimental-design/bofire/issues/320

jduerholt commented 8 months ago

Just one question from my side: why is this checking necessary? When you work with the fixed and partially fixed dataframes, you could just use the input columns which are part of the domain by always stating fixed_experiments[domain.inputs.get_keys()], or not? This would be bit more flexible, what do you think?

jduerholt commented 8 months ago

One question: what happens if the the intersection is empty?

dlinzner-bcs commented 8 months ago

One question: what happens if the the intersection is empty?

The logic is now: 1. Check if all needed columns are present 2. Project dataframe on columns in domain.inputs.get_keys() if 1. fails, you get an informative value error.

jduerholt commented 8 months ago

Somehow tests are failing again ...