search

experimental-design / bofire

Experimental design and (multi-objective) bayesian optimization.
https://experimental-design.github.io/bofire/
BSD 3-Clause "New" or "Revised" License
188 stars 22 forks source link

implement batch constraint for doe #324

Closed KappatC closed 8 months ago

jduerholt commented 8 months ago

@Osburg did the same here: https://github.com/experimental-design/bofire/pull/322

So with which solution should we go on?

KappatC commented 8 months ago

@Osburg did the same here: #322

So with which solution should we go on?

Oh I did not see that one. Sorry, I thought we agreed we would do the doe constraint after you do the polytope sampler and interpoint constraint, but I might as well missunderstood that. Anyways, I am fine with proceeding with Aaron's implementation, since I am still playing around with a formating that would make pyright and black to not complain.

Osburg commented 8 months ago

@KappatC Ah, yes this is possible. Sorry in that case! Was working on the batch constraints this weekend anyways and just continued bc I was already on it...

KappatC commented 8 months ago

@Osburg nw, thanks for working on this in any case. Maybe in the future we just try to coordinate a bit better, so that we don't do duplicate work

jduerholt commented 8 months ago

So, we close this PR and go forward with the one from @Osburg?

KappatC commented 8 months ago

@jduerholt sure, let me play a bit around it first and then I ll close it

Osburg commented 8 months ago

@Osburg nw, thanks for working on this in any case. Maybe in the future we just try to coordinate a bit better, so that we don't do duplicate work

yes, sure, this was my bad! Will watch out better next time!

KappatC commented 8 months ago

closing due to duplicate with #322