Closed KappatC closed 8 months ago
@Osburg did the same here: #322
So with which solution should we go on?
Oh I did not see that one. Sorry, I thought we agreed we would do the doe constraint after you do the polytope sampler and interpoint constraint, but I might as well missunderstood that. Anyways, I am fine with proceeding with Aaron's implementation, since I am still playing around with a formating that would make pyright and black to not complain.
@KappatC Ah, yes this is possible. Sorry in that case! Was working on the batch constraints this weekend anyways and just continued bc I was already on it...
@Osburg nw, thanks for working on this in any case. Maybe in the future we just try to coordinate a bit better, so that we don't do duplicate work
So, we close this PR and go forward with the one from @Osburg?
@jduerholt sure, let me play a bit around it first and then I ll close it
@Osburg nw, thanks for working on this in any case. Maybe in the future we just try to coordinate a bit better, so that we don't do duplicate work
yes, sure, this was my bad! Will watch out better next time!
closing due to duplicate with #322
@Osburg did the same here: https://github.com/experimental-design/bofire/pull/322
So with which solution should we go on?