search

experimental-design / bofire

Experimental design and (multi-objective) bayesian optimization.
https://experimental-design.github.io/bofire/
BSD 3-Clause "New" or "Revised" License
188 stars 22 forks source link

Compatibility PR for Formulaic 1.0.1 #332

Closed jduerholt closed 7 months ago

jduerholt commented 7 months ago

Over the christmas period, formulaic 1.0.1 was released, which was breaking our tests. This PR fixes it.

cc: @Osburg, I am currently not able to assign you as a reviewer, but would be nice if you also can have a look ;)

Osburg commented 7 months ago

Hey @jduerholt looks good to me. If I understood correctly formulaic just handles {...} model terms a little differently now (and does not remove whitespaces in these model terms anymore).

jduerholt commented 7 months ago

Yep, in formulaic before 1.0.1 x**2 was handled as x**2, now it is x ** 2. I will then just merge it in ;)