experimental-design / bofire

Experimental design and (multi-objective) bayesian optimization.
https://experimental-design.github.io/bofire/
BSD 3-Clause "New" or "Revised" License
188 stars 22 forks source link

Transforms #355

Closed bertiqwerty closed 5 months ago

bertiqwerty commented 6 months ago

Implement Transforms

For instance, they they can be applied to steps in the step-wise strategy. This way you can for example change data or candidates the strategies for certain steps or restrict the domain.

R-M-Lee commented 6 months ago

I took a quick look at this. I think that the name RemoveTransform is a little bit confusing because I would expect it to remove the transform rather than be a transform that removes something. What do you think of DropDataTransform or ExcludeTransform?

bertiqwerty commented 5 months ago

I took a quick look at this. I think that the name RemoveTransform is a little bit confusing because I would expect it to remove the transform rather than be a transform that removes something. What do you think of DropDataTransform or ExcludeTransform?

Yes! As so often a great naming suggestion from you!

bertiqwerty commented 5 months ago

namely where it is checked that the acutal drop data transfrom works and drops the correct data, so to say, testing of its functionality.

There was a test in the stepwise-file. I moved it to a separate file and extended it.

bertiqwerty commented 5 months ago

Looks good to me, last minor thing would be to not have test_transforms.py under tests/bofire/strategegies but in a new folder tests/bofire/stransforms.py so that we reflect the correct folder structure. If one is very strict we would also need the test_conditions in the data_models part of the test suite.

Thanks for the review.

Since transforms are tight to the stepwise strategy I will leave the tests there. We can move them later.