Closed jduerholt closed 6 days ago
I also added some tests, and not that I return as jacobian just the diagonal elements of the full matrix.
Hi @jduerholt,
hmm, on my machine the tests are not failing... possible that they just randomly failed? <-- seems like this is the case. Apart from this: do my additions roughly look like you wanted it?
Cheers Aaron :)
Hi @jduerholt :)
is this one ready to be merged? (don't want to approve my own changes without showing it to sb before :D)
cheers Aaron
Hi @Osburg,
thx for the reminder, I will have a look over the week.
Best,
Johannes
Hey Johannes,
sry for being inactive for so long, I was very busy with university recently. I removed the TransformEnum
and added validators for the feature range. Does it look somewhat similar to what you had in mind?
I think the error in type checking comes from pytorch see here
Cheers Aaron :)
In the PR, also the typing issue is fixed.
So just merge main into your branch, as the PR is already accepted.
Hey! in the current version the new Bounds
type is used instead. Does it look ok to you now? :)
Perfect, I did not know that this was working. I will then make the two changes this evening and merge it then in. Thanks!
Hi @Osburg,
this is my interpretation of the scaling as discussed in https://github.com/experimental-design/bofire/pull/354 and https://github.com/experimental-design/bofire/issues/343.
What do you think? No testing etc. yet.
Feel also free, to proceed just from this PR, of course only if you want ;)
Best,
Johannes