search

expersso / OECD

Reproducible and programmatic access to OECD data
126 stars 20 forks source link

OECD package maintenance #21

Open xtimbeau opened 2 years ago

xtimbeau commented 2 years ago

Hi there seems to be a change in the datastructure, as some fuinctions of the package are not functionning anymore (they were a few weeks ago). for instance: OECD::get_data_structure("SNA_TABLE11") throws an error 

Error in data.frame(data_structure@concepts) : 
  trying to get slot "concepts" from an object (class "data.frame") that is not an S4 object

It doesn't looks like it very heavy but it would be nice if done. By the way, some data fileds have changed names, which is not really cool.

xtimbeau commented 2 years ago

it's back! Working again.

mjantti commented 2 years ago

I had the same problem working with the CRAN version, which was fixed by installing instead the development version from github. Now, on the other hand, I get an error using get_dataset(). I tested replacing (as done in get_data_structure) readsdmx::read_sdmx() with rsdmx::readSDMX followed by an as.data.frame, which seems to work. Such hacking seems clunky though.

mabuimo commented 2 years ago

The get_data_structure function is not working properly in the CRAN version

OECD::get_data_structure("DUR_D") Error in data.frame(data_structure@concepts) : trying to get slot "concepts" from an object (class "data.frame") that is not an S4 object

drchriscole commented 2 years ago

I get this error with both the CRAN and github versions.