get_dataset() fails on request

nreigl commented 6 years ago

Probably related to #7

Trying to run the example given in Alternative data-acquisition strategy

library(OECD)

df <- get_dataset("PATS_REGION",
                  filter = "PCT_A.INVENTORS.BEL+BE10.TOTAL+BIOTECH", 
                  pre_formatted = TRUE)

fails with

<XMLInputError: XML content does not seem to be XML: ''>

Problem first emerged Saturday (16.06.2018) evening.

sessionInfo()
R version 3.4.4 (2018-03-15)
Platform: x86_64-w64-mingw32/x64 (64-bit)
Running under: Windows 7 x64 (build 7601) Service Pack 1

Matrix products: default

locale:
[1] LC_COLLATE=Estonian_Estonia.1257  LC_CTYPE=Estonian_Estonia.1257    LC_MONETARY=Estonian_Estonia.1257 LC_NUMERIC=C                     
[5] LC_TIME=Estonian_Estonia.1257    

attached base packages:
[1] stats     graphics  grDevices utils     datasets  methods   base     

other attached packages:
[1] OECD_0.2.2.999

loaded via a namespace (and not attached):
 [1] httr_1.3.1      compiler_3.4.4  rsdmx_0.5-11    plyr_1.8.4      R6_2.2.2        tools_3.4.4     RCurl_1.95-4.10 yaml_2.1.19     Rcpp_0.12.17   
[10] bitops_1.0-6    XML_3.98-1.11

shloonee commented 6 years ago

I experienced the same error, meanwhile it changed to:

Extra content at the end of the document <XMLParserErrorList: 1: Extra content at the end of the document

Result is still the same: no data.

sessionInfo() R version 3.2.3 (2015-12-10) Platform: x86_64-pc-linux-gnu (64-bit) Running under: Ubuntu 16.04.4 LTS

locale: [1] LC_CTYPE=en_US.UTF-8 LC_NUMERIC=C LC_TIME=en_US.UTF-8 LC_COLLATE=en_US.UTF-8
[5] LC_MONETARY=en_US.UTF-8 LC_MESSAGES=en_US.UTF-8 LC_PAPER=en_US.UTF-8 LC_NAME=C
[9] LC_ADDRESS=C LC_TELEPHONE=C LC_MEASUREMENT=en_US.UTF-8 LC_IDENTIFICATION=C

attached base packages: [1] stats graphics grDevices utils datasets methods base

other attached packages: [1] rsdmx_0.5-11 zoo_1.8-2 Hmisc_4.1-1 ggplot2_2.2.1 Formula_1.2-3 survival_2.42-3 lattice_0.20-33 [8] OECD_0.2.2

loaded via a namespace (and not attached): [1] Rcpp_0.12.17 pillar_1.2.3 RColorBrewer_1.1-2 plyr_1.8.4 bitops_1.0-6
[6] base64enc_0.1-3 tools_3.2.3 rpart_4.1-10 digest_0.6.15 tibble_1.4.2
[11] gtable_0.2.0 htmlTable_1.12 checkmate_1.8.5 rlang_0.2.1 Matrix_1.2-3
[16] rstudioapi_0.7 curl_3.2 yaml_2.1.19 gridExtra_2.3 httr_1.3.1
[21] stringr_1.3.1 cluster_2.0.3 knitr_1.20 htmlwidgets_1.2 grid_3.2.3
[26] nnet_7.3-12 data.table_1.11.4 R6_2.2.2 XML_3.98-1.11 foreign_0.8-66
[31] latticeExtra_0.6-28 magrittr_1.5 scales_0.5.0 backports_1.1.2 htmltools_0.3.6
[36] splines_3.2.3 colorspace_1.3-2 utf8_1.1.4 stringi_1.2.3 acepack_1.4.1
[41] RCurl_1.95-4.10 lazyeval_0.2.1 munsell_0.5.0 crayon_1.3.4

migari77 commented 6 years ago

I am having the same issue! Any ideas what is happening? When running the same exact code some weeks ago it was working fine.

Extra content at the end of the document <XMLParserErrorList: 1: Extra content at the end of the document

Error in data.frame(data_structure@concepts) : trying to get slot "concepts" from an object of a basic class ("NULL") with no slots

expersso commented 6 years ago

I find this curious, because it's working fine for me. My hunch is that it's related to the OECD changing to https. Could it be that you're behind proxies and haven't set your https_proxy environmental variable, e.g. Sys.setenv("https_proxy" = "https://abc@def.com:8080"?

shloonee commented 6 years ago

I must admit I cannot rule this completely out (running RStudio Server on Google Compute Engine) but I do not experience any difficulties getting other data from http or https sources.

expersso commented 6 years ago

Since I can't replicate the problem, you could try to install patch #9 by running devtools::install_github("expersso/OECD#9). I've changed the scheme to https in all calls in that patch.

shloonee commented 6 years ago

devtools::install_github("expersso/OECD#9") helped fix the problem in my case. Thx a lot!

nreigl commented 6 years ago

Installing patch #9 solved the problem for me. Thanks a lot.

expersso / OECD

get_dataset() fails on request #8