Removed visibility rule only for Create/ Update

expertasolutions / AzDo.GoDaddyDNS

Tasks packages to manage GoDaddy DNS Zone from Azure DevOps release pipeline.

MIT License

1 stars 2 forks source link

Removed visibility rule only for Create/ Update #10

Closed mkswd closed 4 years ago

mkswd commented 4 years ago

Removed line: "visibleRule": "actionType = createUpdate" Reason: When Action type is Remove, alias is removed from the editor. If you try to remove you get this error: ##[error]Input required: alias

lturmel commented 4 years ago

Hi @mkswd, thanks for the PullRequest and about your contribution, I will review it during the weekend. Best regard :)

lturmel commented 4 years ago

Unfortunatly, I've to not allow that fix, because I want to keep that visibleRule active and hide the field hidden when the actionType is set to Remove. To correct this behavior, when "Remove" is set, I add a defaultValue on requiredField, and change the way that the code get value too. That way we can avoid having that problem encounted when actionType is set to "Remove".

Thanks you for your contribution, that will let me to change it too inside my AzureDNSZoneManagerExtension too