search

expez / evil-smartparens

Evil integration for Smartparens
GNU General Public License v3.0
134 stars 17 forks source link

Add `evil-sp-change' to 'evil-change-commands' #41

Closed jgkamat closed 6 years ago

jgkamat commented 7 years ago

I recently added a new variable to evil, evil-change-commands which allows some evil-change settings (evil-want-change-word-to-end) to be applied to evil-sp-change and similar commands.

Since your function is a replacement for evil-change, it probably should get the same workarounds.

This should fix the dangling issues left in https://github.com/expez/evil-smartparens/issues/20.

Please see https://github.com/emacs-evil/evil/issues/916 for more information.

Let me know if you find any issues with this setup, or if you think it can be implemented in a better way.

(also, I never tested this manually, I'm relying on the test you added to verify it's working correctly). The tests seem to pass locally but not on travis.

expez commented 6 years ago

Thanks, @jgkamat!

Somehow I managed to miss the notification and this ended up sitting here for too long. Sorry about that!