search

expez / evil-smartparens

Evil integration for Smartparens
GNU General Public License v3.0
134 stars 17 forks source link

Evil-smartparens overrides "o" in visual state #48

Open TheBB opened 6 years ago

TheBB commented 6 years ago

I don't know about you, but I consider this to be a bit of an issue, I use the default meaning of "o" fairly frequently. Please consider using another key for this.

Moreover, the binding is added in evil-sp--add-bindings, a function that whenever the mode is enabled (in every buffer). That shouldn't be necessary, the bindings should only have to be made once. The upshot of this is that I can't simply unbind the key once, either, I need to use a hook or an advise to do it, which is a little awkward. If you don't want to move the binding I'd appreciate if it was a little easier to change it.

expez commented 6 years ago

Makes sense.

What does o do? I'm pretty sure this binding wasn't available in evil when I wrote this package. At least I hope not!

I'll add this to my list, but I don't have much time for OSS lately unfortunately. In other words, I'd love a PR ;)

TheBB commented 6 years ago

I'll give it a shot.

It moves the cursor between the two ends of the region, e.g. you could press v, hold l to expand the region to the right, then press o and hold h to expand it to the left.