search

expfactory / expfactory-battery

version 1.0 expfactory battery template used with psiturk, django, and expfactory.github.io
MIT License
0 stars 11 forks source link

Fixed jsyspsych-poldrack-survey-multi-choice.js to correctly display … #21

Closed zenkavi closed 8 years ago

zenkavi commented 8 years ago

…options that are not horizontal and added parameter survey_name to update data with exp_id variable. Also updated default.css to reflect the styling changes for the plugin and the documentation with the description of the new parameter for the plugin.

vsoch commented 8 years ago

This looks ok to me. Quick clarification: the exp_id variable will always be found in the experiment.js file, correct? That is where I am writing the test to find it.

zenkavi commented 8 years ago

each survey so far consists of four blocks: welcome, instructions, survey and end. exp_id will be found in experiment.js for the welcome, instructions and end blocks. for the survey block it will be in the output data which is specified by the survey_name parameter. will that be problematic?

vsoch commented 8 years ago

I think "survey_name" should be "exp_id" - is there a reason to have it named "survey_name" (is it a jspsych standard?) I'm still writing and figuring out the test, but generally we always want to have "exp_id" defined when there is a data object.

zenkavi commented 8 years ago

@vsoch changed the name of the parameter in the plugin now. let me know if this would work with the tests now or if there are other changes

vsoch commented 8 years ago

As long as it's defined in the static experiment.js file, the test will pass. We don't test the plugins.

vsoch commented 8 years ago

oops this was for Ian's PR, wrong one, heh

zenkavi commented 8 years ago

no worries. so is this is merge-able?

vsoch commented 8 years ago

Make sure it's up to date with master (I don't remember if @IanEisenberg did any changes) and then I think it should be ok. Generally I can't say a lot about the battery files because there are no real tests for it other than if/when experiments work.