search

expipiplus1 / vulkan

Haskell bindings for Vulkan
https://hackage.haskell.org/package/vulkan
BSD 3-Clause "New" or "Revised" License
139 stars 31 forks source link

Fix forward type family in boot file (9.8.2) #526

Closed alt-romes closed 1 month ago

alt-romes commented 2 months ago

Fixes an hs-boot file which had an incorrect forward declaration of a closed type family. vulkan would successfully compile despite the hs-boot error with 9.8.1, but not with 9.8.2 because of bug fixes which makes the compiler now reject this invalid program.

We need to use the weird type family A x where .. (with two literal dots after where) to declare the type family in the boot file.

alt-romes commented 2 months ago

I realise now that these sources may be autogenerated. Where could I do this change correctly @expipiplus1 ?

k355l3r-5yndr0m3 commented 1 month ago

@alt-romes Reading the code, I think I found the line that need to change. https://github.com/expipiplus1/vulkan/blob/474ea9dbf4ad36af4afc59d792ffe68549bb46b0/generate-new/src/Render/Spec/Extends.hs#L187-L195

alt-romes commented 1 month ago

@dpwiz I've updated this patch to change the bindings generation code. The CI failures look unrelated to this patch.