search

expired6978 / CUEORGBPlugin

Custom iCUE plugin to control OpenRGB from within iCUE
MIT License
72 stars 13 forks source link

Multiple device lightning is not working as expected #13

Open rbcet opened 3 years ago

rbcet commented 3 years ago

image This is my settings.json.

For example when I select this: image

Mobo, gpu, mousemat, mouse everything becomes yellow. It is acting like lightning but it is just static color. And lightning layers carry over those devices: image

I can give different colors on OpenRGB.

rbcet commented 3 years ago

The problem is that: https://github.com/expired6978/CUEORGBPlugin/blob/9af7f27e132360b99272d5ffe9cc9b22aaea8a02/CUESDKDevice.h#L185

On this line DeviceType's are wrong.

https://github.com/CorsairOfficial/cue-sdk-node/blob/2c4d5387634b2af470f60d2af204235d58b4f9bd/src/enums.js#L1

This should be the enum here. And when you check here, https://github.com/expired6978/CUEORGBPlugin/blob/9af7f27e132360b99272d5ffe9cc9b22aaea8a02/CorsairPluginDevice.cpp#L40

This is actually not keyboard but Mouse. Since 1 corresponds to Mouse in the correct enum.

The issue is that when you set every device as Keyboard, on multiple devices it acts as a single one.

I tried using different deviceTypes. I can use these without a problem, CDT_Mouse CDT_MouseMat CDT_Headset

But the other ones, I can not set any lights for example CDT_GraphicsCard, it won't work in the icue. Maybe these needs different creating method?

rbcet commented 3 years ago

Example to use 3 devices corrrectly: image