search

expitau / InfiniteCraftWiki

A crafting guide for neal.fun's infinite craft
84 stars 15 forks source link

Importing save files breaks because of "+" #12

Closed reumarks closed 5 months ago

reumarks commented 5 months ago

Due to some sort of encoding in the browser, the current bookmarklet script to denote elements that the user already has and add them to saveData array does not work for any elements that contain a "+" in their encoding.

This is most easily seen with "River", since it is one of the first elements to have a "+" in its elementId. If you have river in Infinite craft, and then import your data into the Wiki, you will notice that river does not appear.

I'm nearly finished a decently sized PR that that adds the importing functionality into the main website directly and then uses that to show much simpler crafting recipes (at the cost of a little bit of loading time, but not actually that bad with some optimizations), so having this fixed would be great since it is a decently noticeable error.

expitau commented 5 months ago

Interesting! I look forward to it, I'll take a look and see what's happening

reumarks commented 5 months ago

Yeah it's great, I'm basically developing the bookmarklet system in a way that is perfectly seamless for the user! No need to copy and paste anything -- and because of the way that it is implemented, we are able to update all of the functionality just by pushing changes to the repo since the bookmarklet just embeds an Iframe that does all the work, meaning that 99% of the changes we might want to implement won't require them to update the bookmarklet themselves, and we can fix bugs and push new features instantly for everyone.

expitau commented 5 months ago

+ in bookmarklet should be fixed in most recent update