Closed billh0420 closed 1 year ago
I didn't expected that fixing this type of warnings with promises will be such simple (however, I didn't investigate this problem either). Yes, please submit a PR. And thanks for providing detailed explanations of your changes. If it will be easier for you, in similar cases, you may submit a PR first, so you will not need to explain changes in words, I will see them in the diff. Of course, I don't promise that I will merge the PR in such case, but if it will be easier for you why not.
Since we are using version 10.1.4+ of rescript, there is no need to have an alias for 'promise'.
You can check on there web page at https://rescript-lang.org/docs/manual/latest/promise:
Since 10.1 In ReScript, every JS promise is represented with the globally available promise<'a> type. For ReScript versions < 10.1, use its original alias Js.Promise.t<'a> instead.
To eliminate the warning 44, the following changes need to be made:
A) delete line 1 of the file src/rescript-utils/main/Expln_utils_promise.resi:
B) delete the corresponding line from src/rescript-utils/main/Expln_utils_promise.resi
C) Change line 25 of the file src/metamath/worker/MM_wrk_unify.resi from:
to:
If you wish, I can submit a pull request.