search

expln / metamath-lamp

Metamath-lamp (Lite Assistant for Metamath Proofs) is a GUI-based proof assistant for creating formal mathematical proofs in Metamath that does not require installation (just run it directly using your web browser).
https://expln.github.io/lamp/latest/index.html
MIT License
12 stars 5 forks source link

Eliminate the legacy ReactDOMRe #139

Closed billh0420 closed 1 year ago

billh0420 commented 1 year ago

Note that I could have used instead of Some(resultRef.contents):

`

Some({
      style:?createStyle(attrs,~addBorder),
      href:?(attrs->Belt_MapString.get("href")),
      title:?(attrs->Belt_MapString.get("href")),
      target:?(attrs->Belt_MapString.get("href")->Belt_Option.map(_ => "_blank")),
})

`

But, this adds all 4 fields to the record (which can be seen in the debugger) with optional fields having the value 'undefined'. The original method didn't have this problem since it used the legacy function ReactDOMRe.domProps.

The only way that I could duplicate the original was to use the spread "..." functionality.