search

explodinggradients / ragas

Supercharge Your LLM Application Evaluations 🚀
https://docs.ragas.io
Apache License 2.0
7.3k stars 746 forks source link

Update _factual_correctness.py #1656

Closed yousoferfani closed 1 week ago

yousoferfani commented 1 week ago

The recall metric formula should change to tp/(tp+fn)

jjmachan commented 1 week ago

hey @yousoferfani thanks a lot for catching this #1650 this also fixes the same thing so closing this in favor of that

the fix will be released now

yousoferfani commented 1 week ago

Sure Thanks

On Tue, Nov 12, 2024 at 10:54 AM Jithin James @.***> wrote:

hey @yousoferfani https://github.com/yousoferfani thanks a lot for catching this #1650 https://github.com/explodinggradients/ragas/pull/1650 this also fixes the same thing so closing this in favor of that

the fix will be released now

— Reply to this email directly, view it on GitHub https://github.com/explodinggradients/ragas/pull/1656#issuecomment-2471320208, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADUD2LZNFKJZWQHSQ5XB3ZL2AJFG3AVCNFSM6AAAAABRS6GRKGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINZRGMZDAMRQHA . You are receiving this because you were mentioned.Message ID: @.***>

jjmachan commented 1 week ago

but we really appreciate time time you took to fix it, thanks a million 🙌🏽