search

explodybits / hookr-plugin

The official Hookr plugin annotates the html output of your WordPress install with all executed actions/filters.
http://hookr.io
GNU General Public License v2.0
98 stars 19 forks source link

Breaks page using handlebars.js #13

Open chromeo opened 7 years ago

chromeo commented 7 years ago

Great plugin right out of the gate - beautiful interface. I have a page that uses a handlebars.js template, and it works great with no errors or warnings on the 3 major browsers. But when I activate hookr the handlebars rendering engine quits and just spits out the plain markup.

It is certainly possible that I have an error in my template that the renderer silently ignores, but after a cursory code review I'm not seeing it. Using handlebars v4.0.8 via cloudflare, same result served locally.

With hookr disabled:

screenshot 2017-05-08 10 32 15

With hookr enabled:

screenshot 2017-05-08 10 29 30

And the console:

image

explodybits commented 7 years ago

Please send me an example of the broken template-- i need to see the output. Anything would help.

On Monday, May 8, 2017, Gary Darling notifications@github.com wrote:

Great plugin right out of the gate - beautiful interface. I have a page that uses a handlebars.js template, and it works great with no errors or warnings on the 3 major browsers. But when I activate hookr the handlebars rendering engine quits and just spits out the plain markup.

It is certainly possible that I have an error in my template that the renderer silently ignores, but after a cursory code review I'm not seeing it. Using handlebars v4.0.8 via cloudflare, same result served locally. With hookr disabled:

[image: screenshot 2017-05-08 10 32 15] https://cloud.githubusercontent.com/assets/1266796/25816681/ae7645f4-33d9-11e7-8e2a-d63f2ae0c130.png With hookr enabled:

[image: screenshot 2017-05-08 10 29 30] https://cloud.githubusercontent.com/assets/1266796/25816576/564446d8-33d9-11e7-8321-172f49590549.png And the console:

[image: image] https://cloud.githubusercontent.com/assets/1266796/25817744/1466f9fa-33dd-11e7-8d5d-d5b1e7a952a1.png

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/explodybits/hookr-plugin/issues/13, or mute the thread https://github.com/notifications/unsubscribe-auth/AAvfVVUT6A_KMthhaus9p0_t99oHPWYYks5r31fZgaJpZM4NUSQm .

chromeo commented 7 years ago

Here is the handlebars template shown in the image listings-modal.php.zip

explodybits commented 7 years ago

Gary, thanks... I'll look into this today.

On Sun, May 14, 2017 at 11:44 PM, Gary Darling notifications@github.com wrote:

Here is the handlebars template shown in the image listings-modal.php.zip https://github.com/explodybits/hookr-plugin/files/1000041/listings-modal.php.zip

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/explodybits/hookr-plugin/issues/13#issuecomment-301369671, or mute the thread https://github.com/notifications/unsubscribe-auth/AAvfVZACegSK6L_ueAvfpJeCouTe7WzEks5r58oYgaJpZM4NUSQm .

explodybits commented 7 years ago

Gary, instead of the .php, I need to see what is running within the browser-- can you send me the markup by viewing-source/copying?

On Sun, May 14, 2017 at 11:44 PM, Gary Darling notifications@github.com wrote:

Here is the handlebars template shown in the image listings-modal.php.zip https://github.com/explodybits/hookr-plugin/files/1000041/listings-modal.php.zip

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/explodybits/hookr-plugin/issues/13#issuecomment-301369671, or mute the thread https://github.com/notifications/unsubscribe-auth/AAvfVZACegSK6L_ueAvfpJeCouTe7WzEks5r58oYgaJpZM4NUSQm .