search

exploitoverload / PwNixOS

PwNixOS - A Productivity Focused and Hacking-Oriented NixOS Flake
MIT License
78 stars 6 forks source link

quality of life #6

Open NotAShelf opened 2 months ago

NotAShelf commented 2 months ago

Hey! Nice project, but there seems to be a few things that could see some love from the maintainer(s).

  1. The usage of with lib;

Most good nix projects actively avoid with scopes. For better maintainability, those should be replaced with explicit inherits.

  1. Lack of modularity

If this is meant as your personal config, and that only - it's perfectly fine. Otherwise, it will come off as too opinionated and could probably benefit from 1. an internal module system and 2. exposing some of the "pwning" related options as nixosModules that are directly importable from outside.

  1. Confusing structure

Sticking everything in a modules directory is probably a bad idea. Maybe divide things by function so that it's easier to find what you're looking for?

exploitoverload commented 2 months ago

Hi @NotAShelf !

First of all, thank you very much for the comment and for the PR, it helps me a lot to improve this project.

This project started as a personal configuration of my work environment for pentesting and development of hacking tools among others. But it is true that I would like to set up something like what you indicate, a flake focused on facilitating the adoption of hacking tools and configurations for NixOS users.

I will try to follow your suggestions to improve the structure and especially the modules part. The ideal for me would be to keep this project as a system configuration so that users who are developers or pentesters give nixos a chance and at the same time other users who already have their own configuration can import the modules they need or want to test. I don't know if this is possible or not, I need to investigate it yet.

Again thank you very much!!