explorable-viz / fluid-examples

https://explorable-viz.github.io/fluid-examples/
MIT License
1 stars 1 forks source link

Use CSS from Fluid by default #58

Open rolyp opened 2 months ago

rolyp commented 2 months ago

The Methane example works ok as a “standalone” figure but has several problems in https://explorable-viz.github.io/fluid-example-ipcc-ar6-01/ when viewed in Firefox. The culprit is styles.css, which this example provides its own copy of, rather than picking up the version provided by fluid (in particular it still uses zoom, which isn’t supported in Firefox).

rolyp commented 2 months ago

For now it should be possible to fix this (mostly/entirely) by deleting the zoom property from .double-size in styles.css. If some resizing is required the approach taken by styles.css in the Fluid submodule can be used. The longer-term fix I think is to pick up styles.css from Fluid and only override locally when specifically needed.

RaoOfPhysics commented 2 months ago

Works in Firefox now (https://explorable-viz.github.io/fluid-example-ipcc-ar6-01/) but I have to remove the code for .double-size because that was breaking the centring of the plot and wouldn’t show the data sidebar.

Anyway, it works!

Screenshot 2024-09-25 at 17-43-21 Re-implementation of IPCC data in Fluid

RaoOfPhysics commented 2 months ago

https://github.com/explorable-viz/fluid-example-ipcc-ar6-01/commit/c44140cb18f64e396840a1c8335d68d91cafb1f4

rolyp commented 2 weeks ago

This is addressed by explorable-viz/fluid#924, but won’t close this until we come back to https://explorable-viz.github.io/fluid-example-ipcc-ar6-01/.