search

explorer-gaurav / Nimbl3

Nimbl3 Android Developer Test
MIT License
0 stars 1 forks source link

Rest services are duplicated? #3

Open sleepylee opened 6 years ago

sleepylee commented 6 years ago

Not so sure why should we have these Networking modules in 2 places (seems like we only use the one from DI) or can you please elaborate?

explorer-gaurav commented 6 years ago

I am not sure whether you are working on the latest code. I have already removed the CommunicationApi.java class from the code and the networking is happening only from NetworkModule.java.

It would be great if you can pull the code once again.

sleepylee commented 6 years ago

hi @explorer-gaurav, as you can see the attached links above are pointing to master, it's retrievable from github online view.

explorer-gaurav commented 6 years ago

@sleepylee Sincere apologies. I forgot to commit the cleanup I performed at the end.

explorer-gaurav commented 6 years ago

Just pushed the cleanup code. For clarification, CommunicationApi.java was not getting used and the networking is happening only from NetworkModule.java.