search

explosion / cython-blis

💥 Fast matrix-multiplication as a self-contained Python library – no system dependencies!
Other
218 stars 37 forks source link

Support NumPy 2.0 #106

Open jakirkham opened 4 months ago

jakirkham commented 4 months ago

Hi All 👋

NumPy is planning to release 2.0 on June 16th ( https://github.com/numpy/numpy/issues/24300#issuecomment-2125643448 ). NumPy 2.0.0 RC packages for conda & wheels came out at the beginning of April ( https://github.com/numpy/numpy/issues/24300#issuecomment-2030603395 )

NumPy has put out a migration guide. More details are in the release notes

If Cython BLIS makes use of NumPy's C API (and produces wheels that use it), having a release of Cython BLIS with wheels built against NumPy 2.0.0 RC would be helpful to ensure NumPy 1 & 2 compatible wheels (as wheels built against NumPy 1 won't be compatible with NumPy 2). More details in this NumPy 2 ABI doc. Note that Cython is compatible with NumPy 2 so it is possible just configuring builds with NumPy 2 is sufficient

Also as NumPy is tracking ecosystem support for NumPy 2.0, it would be helpful to share Cython BLIS current support status in issue (with any plans): https://github.com/numpy/numpy/issues/26191

honnibal commented 4 months ago

Thanks! Yes this is very much on our radar 👍

jakirkham commented 2 months ago

Am seeing references to NumPy 2 in PR ( https://github.com/explosion/cython-blis/pull/108 ) and v1.0.0

Does that mean this has been addressed?

If so, might be worth noting the NumPy 2 compatible version of Cython BLIS in upstream issue: https://github.com/numpy/numpy/issues/26191

rgommers commented 1 week ago

I've updating the NumPy tracking issue. I think this issue can be closed now.