explosion / preshed

💥 Cython hash tables that assume keys are pre-hashed
MIT License
82 stars 19 forks source link

pip install preshed fails for official python:3.7 docker container #15

Closed jtmoulia closed 6 years ago

jtmoulia commented 6 years ago

Hi, I'm trying to install spacy in the official python:3.7 docker container but I'm getting an error: Failed building wheel for cymem.

Here's the command and the full log:

docker run -it --rm python:3.7 bash -c 'pip install preshed'

Note that running this command using the python:3.6 container works fine.

Let me know if any additional information would be useful!

Russell-Jones-OxPhys commented 6 years ago

preshed fails at

    preshed/maps.cpp:6647:13: error: ‘PyThreadState {aka struct _ts}’ has no member named ‘exc_traceback’; did you mean ‘curexc_traceback’?
         tstate->exc_traceback = *tb;
                 ^~~~~~~~~~~~~
                 curexc_traceback
    error: command 'x86_64-linux-gnu-gcc' failed with exit status 1

which (googleficially) looks like https://github.com/pandas-dev/pandas/issues/21785

jtmoulia commented 6 years ago

Thanks for the tip @Russell-Jones-OxPhys -- I think the issue underlying both is the old version of Cython.

honnibal commented 6 years ago

Thanks @jtmoulia , seems to be the case