search

explosion / sense2vec

🦆 Contextually-keyed word vectors
https://explosion.ai/blog/sense2vec-reloaded
MIT License
1.63k stars 240 forks source link

check lowercase when ignore_case=True #139

Closed chanind closed 3 years ago

chanind commented 3 years ago

get_other_senses and get_best_sense claim to check for lowercase, uppercase, and title case when ignore_case=True. However, they only check for the case that's passed in, upper, and title, but don't check for lowercase. This PR fixes this issue so lowercase is explicitly checked as well.

closes #138

svlandeg commented 3 years ago

Thanks for the contribution, and sorry for the late follow-up! This looks good so I'll go ahead and merge :-)