explosion / spaCy

💫 Industrial-strength Natural Language Processing (NLP) in Python
https://spacy.io
MIT License
30.33k stars 4.41k forks source link

v3.8 fails to build on py3.8 #13645

Open markjm opened 1 month ago

markjm commented 1 month ago

How to reproduce the behaviour

Hi!

in the most recent release, the setup_requires numpy version was updated to a version which is not published for py3.8 https://github.com/explosion/spaCy/blob/master/setup.cfg#L39

1.24 is the last version available for py3.8 https://endoflife.date/numpy#python-support

The current setup.cfg does list 3.8 as still supported https://github.com/explosion/spaCy/blob/master/setup.cfg#L21

If that is true, perhaps the <py3.9 tag here should be downgraded (leaving >3.9 updated)

p.s. i see https://github.com/explosion/spaCy/issues/13624 which looks related

The only solution is to update your Python, or continue using the version of spaCy that's been working for you.

This is a totally reasonable answer, but if thats the case, perhaps it would be best to remove the advertised support for 3.8 in those classifiers (and any other relevant locations)

Thanks so much for the great project!

Your Environment

honnibal commented 1 month ago

Yes I messed up and didn't change the metadata to drop Python3.8, sorry. It's indeed not supported.