Closed ines closed 4 years ago
kormilitzin
commented
5 years ago Hi Ines,
Makes perfect sense. I am bit confused though with
"cats": { "TECHNOLOGY": true, "FINANCE": false, "LEGAL": false },
Do the classification labels correspond to the entire text? In this case, you have both sentences related to technology, but what if two sentences have different labels?
ines
commented
5 years ago Do the classification labels correspond to the entire text? In this case, you have both sentences related to technology, but what if two sentences have different labels?
Yes, the "cats" are labels that refer to the whole text, i.e. the whole document – however you define it. This is the target for spaCy to predict as doc.cats.
Sorry if this was confusing from my example, but the JSON object I've outlined above is only one entry in a list of training examples. So you could have thousands of those objects, split into sentences or larger chunks, whatever you're working with.
justindujardin
commented
5 years ago Speaking of validation: We could also add more in-depth data debugging and warnings (e.g. via an optional flag or command the user can run). For example: "Your data contains a new entity type ANIMAL that currently isn't present in the model. 1) You only have 15 examples of ANIMAL. This likely isn't enough to teach the model anything meaningful about this type. 2) Your data doesn't contain any examples of texts that do not contain an entity. This will make it harder for the model to generalise and learn what's not an entity."
I think this would be a killer addition. Best practices are so hard to come by if you're not an expert or they're not shoved in your face. Please call them out!
DnzzL
commented
5 years ago This is a very good idea, and would be much simpler.
I still don't get the expected json schema for textcat only ...
honnibal
commented
5 years ago After working on this for a bit, there are some annoying problems :(. The problem is that some useful assumptions that make the data easy to work with might not hold true for all corpora. So we have to decide between convenience and fidelity.
spaCy relies on the characters in the tokens matching up with the characters in the raw text. This means we can always say which span of characters in the text corresponds to some token. The tokens can't overlap, and all characters must be either whitespace or within a token.
Not all corpora follow these assumptions. Here are some cases where the gold tokens in a corpus might differ from the raw text:
m while the tokens might have I am.Issues like this come up quite a lot in syntactic annotations, as to get reasonable trees we want to correct some surface errors. For instance, if a text has "the" when the user meant "they're", we'll get a really weird syntactic structure and POS tag sequence if we don't have two tokens. We can make the tokens something like ["th", "e"]. but this is sort of unnatural...So treebanks will often just have the leaves be ["they", "'re"].
A different type of problem is that corpora often don't provide the raw text. I still don't understand why this was standard, but...Here we are. Often all we get is token annotations, and the token annotations don't allow the raw text to be reconstructed.
Together, the two problems create the following dilemmas:
We can't rely on providing character offsets for token, sentence or entity annotations, because: 1a. There might be no raw text to point into 1b. The annotations might be provided with reference to tokens, and the tokens might not align to the raw text losslessly.
We can't rely on providing token offsets for entity annotations, because the corpus might only provide character offsets, with no gold-standard tokenization.
We therefore have the following choice to make. We can either:
a) Insist that the tokens must match the text, and that the raw text always be provided. If the corpus doesn't obey these constraints already, it must be "fixed" before it can be represented in our format.
b) Allow spans (for tokens, entities, sentences etc) to provide either token offsets or character offsets (or both).
The strict approach a is better for spaCy, because the constraint matches an implementation detail of our tokenizer anyway. The permissive approach b is better for inter-operation and allows us to use the same format in more contexts, at the cost of code that uses the format being more annoying to write. For instance, to get the text of all entities, you have to check whether the offsets refer to tokens or the text, and handle the two conditions differently.
adrianeboyd
commented
5 years ago Some initial thoughts:
You want to be able to train using data where the tokenization does not correspond to spacy's internal tokenization, but you want to insist on spacy doing its own tokenization in all models, so you have to do lots of messy alignments no matter whether token or character offsets are provided.
You have the issue that you want to support:
The token list people are going to be annoyed at having to do fiddly character offset conversions with data that's not really meant for it (do you do detokenize or just have whitespace separated tokens in the raw text?), but if you don't change the format, the character offset people can't easily provide their data at all. So I guess character offsets are the more inclusive option here.
(It is weird that the current format has the token text in two places and if you create training data where the tokens and raw text don't correspond, you get None words in your training data with no warnings while training. This should probably be in a separate issue, but in any case I would not recommend having the token text duplicated anywhere.)
Character offsets are an enormous pain to work with if the raw data is not set in stone. If you realize that you need to modify the text at all, you can't quickly edit the training data by hand. Everything basically goes kerplooey. Apparently this isn't a major issue for your typical use cases, but I thought I would mention it anyway.
Even in automatic conversions, it's so easy to get off by a character and not realize it (all those fiddly character offset conversions for token list data) so you'd need to build in some sanity checks that make sure you don't have a lot of tokens covering whitespace and that the non-whitespace characters are covered by the tokens like you expect.
It is too bad that it's hard to include a comment containing the covered character span alongside each span annotation with some kind of verification/lint-type tool, since this is a useful sanity check. I suppose you could add an actual string value to the token, but you'd have to make the name extremely clunky (__auto_covered_text_span__) so people don't get confused and think it's a real orth value.
I think it's going to be difficult to envision every use case here. You could go full TEI-XML for the raw text (wouldn't that be fun! but I'm not entirely joking, see below) and you'd still have cases that aren't covered. (This is related to the discussion about docs vs. paragraphs in #4013 .)
As a kind of compromise, I would suggest adding optional string ID attributes in as many places as possible so that people have the information to reconstruct documents and make the data splits that make sense for their task. I'm imagining d1-p2-s3-t4 kind of IDs down at the token level, just d1 at the doc level, etc., some kind of hash for the sentence text on the sentence level, whatever makes sense. And possibly you'd also want something like metadata / comment for each element instead of mixing this up with IDs. I could imagine a lot of solutions, none particularly elegant, but better than not being able to link the data back to the original corpus.
In MERLIN there were a lot of letters, which contained headers with addresses and greetings and footers with closings and signatures. We had used a custom transcription format that used whitespace to suggest the formatting for right-aligned addresses and other parts of the text. When we wanted to render the formatted texts in our online search results, just inserting space characters didn't really get the right results because of font differences. I regretted that we hadn't annotated more of the basic letter format with some TEI-like tags. PAULA XML would have allowed this with no problem, because the raw text could be XML and then you could annotate the base tokens based on the text spans. The remaining annotation layers referred to the tokens, so it was no problem to have extra characters in the raw text.
I don't think you want to base everything on tokens (or you lose the character spans above) and I think it would be a major change to allow ignored characters in the text, but it would be another option that would allow for document structure that doesn't interfere too much with spacy's training (I would imagine a typical case as HTML snippets) and additional (meta)data without relying on custom metadata packed into IDs in various ways. Most people wouldn't want to use it, but those who did might appreciate it.
(There are still some whitespace issues with things like HTML snippets, since things like <p> insert whitespace between sentences that is not necessarily present in the raw text and things like <i> don't, so it's still kind of non-trivial.)
If you don't think it's too much of a hassle (due to enforcing uniqueness), I would suggest making token IDs mandatory and using them instead of array offsets for the dependencies. It makes things easier to read/debug and to edit, especially as texts get longer. If you want to excerpt a single sentence you just have to adjust the character offsets (or replace everything else in the raw text with whitespace, which is totally something I've done while debugging). If you have token IDs, then you can also have the option of representing other spans as lists of tokens rather than character offsets.
To be clear, the IDs should be allowed to be arbitrary. (See: try adding a word to the beginning of a CONLL-X/U sentence.)
I think the constraint that the token text needs to correspond to the raw text is probably a good idea to keep things simpler.
I would only recommend formally handling normalizations if spacy has a normalization component as part of the pipeline. (Otherwise, what is the model going to learn? What input is it expected to handle?) If you have meaningful IDs/metadata, you can track down the original raw text or the original normalizations as you need to for other purposes, and keep the data in the format that you intend to handle in the model in the training data.
There are some technical issues that can come up, too. The main one is that inserting multiple tokens at the same position gets tricky if you're only relying on character offsets because there's no foolproof way to represent the order of the insertions.
Similar to what's happened with CONLL formats, I think you're going to regret calling everything a "spacy JSON(L) format" and relying on file endings to know how to parse things. I think it might be useful to have an optional version/format value somewhere at the top level in the JSON data.
johnwdubois
commented
4 years ago These are very important issues to address. Adrianeboyd's observations about the value of tokens with ID values is important, especially when the data can change, or when there are complexities with normalization and/or non-alphabetic characters ("punctuation"). This is especially likely to happen when working with a corpus of conversational transcriptions, as we do. In using Spacy to tokenize and tag the Santa Barbara Corpus of Spoken American English, we had to go through many elaborate contortions to get Spacy to pay attention just to the legitimate tokens, while ignoring aspects of the transcription that do not correspond to lexical words (but which are ultimately important for studying prosody, etc.). A token id approach would make this a lot easier, and would allow Spacy to contribute its considerable value to the study of spoken language.
adrianeboyd
commented
4 years ago In spacy v3.0 the JSON format will be replaced with training from Example objects, where the reference (gold) annotation is provided directly by a Doc object instead of being read in from an alternate format. A preview of v3.0 is now available through the spacy-nightly release, here are the details for the new Example class: https://nightly.spacy.io/api/example
Any annotation you can add to a Doc can potentially be used by a component in training and prediction, including custom extensions. A corpus of Doc objects can be serialized very compactly as a DocBin, which is much much smaller on disk than the v2 JSON format.
github-actions[bot]
commented
3 years ago This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Motivation
One of the biggest invonveniences and sources of frustration is spaCy's current JSON format for training. It's weirdly specific, annoying to create outside of the built-in converters and difficult to read. Training the model with incomplete information is pretty unintuitive and inconvenient as well.
To finally fix this, here's my proposal for a new and simplfied training file format that is easier to read, generate and compose.
Example
Notes
"text"and optional"ents"(named entity spans),"sents"(sentence spans),"cats"(text categories) and"tokens"(tokens with offsets into the text and optional attributes)."start"(start index) and"end"(end index). Other attributes match spaCy's API."tokens"don't have to include all attributes. If an attribute isn't present (e.g. a part-of-speech tag or dependency label), it's treated as a missing value."head"is the index of the head token, i.e.token.head.i.spacy.gold.docs2jsonhelper that generates the training format fromDocobjects. It's intended to help keep the converters (.conlluetc.) in sync, since they can now all produceDocobjects and call into the same helper to convert to spaCy's format. This would also make the transition to a new format easy, because we'd only have to change the logic indocs2json.✅ Pros
"tokens"and only train on the"ents"or update the"sents"to improve the sentence boundary detection.💡 Related ideas
ANIMALthat currently isn't present in the model. 1) You only have 15 examples ofANIMAL. This likely isn't enough to teach the model anything meaningful about this type. 2) Your data doesn't contain any examples of texts that do not contain an entity. This will make it harder for the model to generalise and learn what's not an entity."spacy trainaccept data in both.jsonand.jsonl(newline-delimited JSON). JSONL allows reading the file in line-by-line and doesn't require parsing the entire document.spacy trainshould make it much easier to update existing models or, alternatively, we should provide an analogous command with the same / similar arguments that takes the name of an existing model package instead of just the language to initialize. (Basically, if you know Prodigy, we want to provide the same smooth batch training experience natively in spaCy!)begin_trainingandupdatemethods on components (if you callnlp.update, spaCy will iterate over the components and call theirupdatemethods if available – just likenlp.from_disk). So we could, for instance, allow an_space in the training data, just like in the custom extension attributes, that can contain additional data – think coreference annotations, entity links etc.! Those would then automatically be added to the gold-standardDocand become available in the custom component'supdatemethod.What do you think? I'd love to hear your feedback in the comments!