explosion / spacy-stanza

💥 Use the latest Stanza (StanfordNLP) research models directly in spaCy
MIT License
723 stars 59 forks source link

Add support for stanza 1.7 and 1.8 #102

Open michael-k opened 2 months ago

michael-k commented 2 months ago

Tests are green with explosion/spacy-stanza#101. They fail because emoji 2.12.0 (a dependency of stanza) doesn't have a lower bound on typing-extensions (see carpedm20/emoji#297), but spacy has an upper bound ( :cry: ).

There are other ways to fix this¹ apart from dropping support for Python < 3.8, but with 3.7 being beyond its lifespan for almost 1 year and your work on spacy 4 (although I don't know when to expect this), I don't think its worth it.

Also: That the tests for Python 3.7 fail is unrelated to this PR. They fail for the default branch as well.

¹Eg. relax the upper bound in spacy or disallow emoji 2.12.0 to be installed