explosion / spacy-stanza

💥 Use the latest Stanza (StanfordNLP) research models directly in spaCy
MIT License
723 stars 59 forks source link

Get language attribute directly from Stanza pipeline object #36

Closed yuhaozhang closed 4 years ago

yuhaozhang commented 4 years ago

Starting from Stanza v1.0.1, lang has been an attribute of the pipeline object: https://github.com/stanfordnlp/stanza/blob/82afe7fbfe51f30c878959f65909a6cc64ee14ab/stanza/pipeline/core.py#L68

This PR adapts the spacy-stanza pipeline initialization to this change, while maintaining some backward compatibility with Stanza v1.0.0.

ines commented 4 years ago

Thanks so much for the PR and sorry for only getting to this now! Will push a new release with this later 🙂

yuhaozhang commented 4 years ago

No worries! Thanks for merging it!