search

explosion / spacy-stanza

💥 Use the latest Stanza (StanfordNLP) research models directly in spaCy
MIT License
723 stars 59 forks source link

Don't restrict minor version of stanza #73

Closed BramVanroy closed 3 years ago

BramVanroy commented 3 years ago

Usually minor versions should not contain breaking changes so it should be fine to have this to <2.0 for now.

Restricting to <1.3.0 makes spacy-stanza incompatible with current dev branch of stanza. (I incorrectly mention in the commit incompatibility with stanza's master, but that is incorrect (which is at 1.2.1). dev is at 1.3.0)

adrianeboyd commented 3 years ago

Since minor version updates do have the potential to break things in unexpected ways, we'd generally rather test new releases first and then release a new version with the expanded compatibility range.

We do make a few exceptions in the requirements for libraries that are generally stable, predictable, and tested by many people as release candidates (numpy, torch), but even torch v1.9.0 broke thinc two weeks ago.

BramVanroy commented 3 years ago

I guess that's fair. If everyone would just stick to semantic versioning guidelines of only introducing breaking changes in major versions, the world would be an... easier-world-to-version-things place.