`pygls > 1.0.x` breaks version checks

explosion / spacy-vscode

spaCy extension for Visual Studio Code

MIT License

25 stars 4 forks source link

`pygls > 1.0.x` breaks version checks #30

Open shadeMe opened 10 months ago

shadeMe commented 10 months ago

pygls 1.1 seems to have removed the __version__ attribute from the top-level module, which breaks the validation code.

adrianeboyd commented 10 months ago

Checking versions for python 3.7+ is annoying due to the lack of importlib.metadata in python 3.7.

If you switch this to python 3.8+ you can use importlib.metadata instead. For python 3.7+ you could use importlib_metadata from spacy.compat. You'd have to refactor the version checking code a bit to import spacy first/separately.