Preserve values with dtype for NumpyOps/CupyOps.asarray

explosion / thinc

🔮 A refreshing functional take on deep learning, compatible with your favorite libraries

https://thinc.ai

MIT License

2.82k stars 275 forks source link

Preserve values with dtype for NumpyOps/CupyOps.asarray #897

Closed adrianeboyd closed 1 year ago

adrianeboyd commented 1 year ago

Description

Always specify dtype when creating new arrays so that large integer values are preserved and not at risk of going through an intermediate float64 conversion.

Types of change

Bug fix.

Checklist

[x] I confirm that I have the right to submit this contribution under the project's MIT license.
[x] I ran the tests, and all new and existing tests passed.
[x] My changes don't require a change to the documentation, or if they do, I've added all required information.

adrianeboyd commented 1 year ago

@explosion-bot please test_gpu

explosion-bot commented 1 year ago

🪁 Successfully triggered build on Buildkite

URL: https://buildkite.com/explosion-ai/thinc-gpu-test-suite/builds/111