Replace pkg_resources with pip install --dry-run

explosion / weasel

🦦 weasel: A small and easy workflow system

MIT License

63 stars 8 forks source link

Replace pkg_resources with pip install --dry-run #44

Closed adrianeboyd closed 1 year ago

adrianeboyd commented 1 year ago

Description

Replace deprecated pkg_resources with minimal handling of the output of pip install --dry-run in cases where packages need to be installed (depends on the text output of pip install) or the requirements contain conflicts or other errors (depends on the return code of pip install).

Types of change

Checklist

[x] I confirm that I have the right to submit this contribution under the project's MIT license.
[x] I ran the test suite, and all new and existing tests passed.
[x] My changes don't require a change to the documentation, or if they do, I've added all required information.

adrianeboyd commented 1 year ago

It's brittle, but there's no pip API, and in the worst case it just doesn't warn.

adrianeboyd commented 1 year ago

I'm trying to think of the case where people definitely want the requirements to be checked and they might otherwise keep running into silent failures.

None of this is great.

svlandeg commented 1 year ago

If we worry about either scenario, we should still consider hooking up the skip_requirements_check and allow users to control this behaviour. It doesn't make things more complex for users who don't use/need the flag.

adrianeboyd commented 1 year ago

I might be more tempted to just throw it out with the transition to weasel.

adrianeboyd commented 1 year ago

I think we could say that we're removing this because pkg_resources is deprecated and that would be okay.

svlandeg commented 1 year ago

Honestly I don't care strongly either way Adriane.

adrianeboyd commented 1 year ago

Then I'll remove it. It never really worked 100% properly anyway.

adrianeboyd commented 1 year ago

Replaced by #49.