Error when using a file in a git repository as an asset in spacy projects config

[b2m]

Using a file in a git repository as an asset in a spacy project configuration fails because the code expects only directories.

How to reproduce the behaviour

Use a file in a git repository as an asset in the projects.yml as described in the documentation:

path: Path of the file or directory to download, relative to the repo root.

Here is a code example trying to use spacy's citation file as an asset:

assets:
  - dest: "spacy-citation.cff"
    git:
      repo: "https://github.com/explosion/spaCy"
      branch: "master"
      path: "CITATION.cff"

Then run spacy project assets which fails with the following (reduced) stacktrace:

Traceback (most recent call last):
 ...
  File "/venv/lib/python3.8/site-packages/spacy/cli/project/assets.py", line 39, in project_assets_cli
    project_assets(
  File "/venv/lib/python3.8/site-packages/spacy/cli/project/assets.py", line 105, in project_assets
    git_checkout(
  File "/venv/lib/python3.8/site-packages/spacy/cli/_util.py", line 407, in git_checkout
    shutil.copytree(str(source_path), str(dest))
  File "/usr/lib/python3.8/shutil.py", line 555, in copytree
    with os.scandir(src) as itr:
NotADirectoryError: [Errno 20] Not a directory: '/tmp/tmpw_23425/CITATION.cff'

The reason for the error is that shutil.copytree expects a directory and not a single file.

Your Environment

• Operating System: Ubuntu 20.04
• Python Version Used: 3.8.10
• spaCy Version Used: 3.4.4

[danieldk]

Thank you for reporting this issue! I can reproduce it and am currently working on a fix.

[adrianeboyd]

We would need to port https://github.com/explosion/spaCy/pull/12181 to weasel.