search

explosivo22 / rinnaicontrolr-ha

Rinnai Control-R integration for Home Assistant
Apache License 2.0
50 stars 3 forks source link

Deprecated Constants Warning in HA 2024 logs #76

Closed Ramias1 closed 6 months ago

Ramias1 commented 8 months ago

Getting these messages in my log files; does not currently break functionality.

DEVICE_CLASS_TEMPERATURE was used from rinnai, this is a deprecated constant which will be removed in HA Core 2025.1. Use SensorDeviceClass.TEMPERATURE instead, please report it to the author of the 'rinnai' custom integration
ELECTRIC_CURRENT_MILLIAMPERE was used from rinnai, this is a deprecated constant which will be removed in HA Core 2025.1. Use UnitOfElectricCurrent.MILLIAMPERE instead, please report it to the author of the 'rinnai' custom integration
FREQUENCY_HERTZ was used from rinnai, this is a deprecated constant which will be removed in HA Core 2025.1. Use UnitOfFrequency.HERTZ instead, please report it to the author of the 'rinnai' custom integration
morikplay commented 6 months ago

Hello, I use this integration, and have made the rather benign changes, directly in sensor.py using Visual Studio Code. Reload of component does not indicate any errors. How best shall i go about submitting it to the repository? I'm rather new to HA, and do not yet have a dev environment setup.

wrmacj commented 6 months ago

That Hey @morikplay, would you make the changes that you made available so that we can get a head of this. Thanks for your help in getting this resolved.

explosivo22 commented 6 months ago

Apologies all on getting behind on this. Will hopefully have this published later today.

morikplay commented 5 months ago

Apologies to @wrmacj and @explosivo22 for the delayed response. I see that changes in here are identical to mine. All good.

explosivo22 commented 5 months ago

@morikplay No worries. Good of you to get in and get your hands dirty and figure it out before I could get to it. I'm glad our stuff matches.