search

explosivo22 / rinnaicontrolr

Python interface for the Rinnai Control-R API
Apache License 2.0
12 stars 3 forks source link

keep internals internal #1

Closed dulitz closed 3 years ago

dulitz commented 3 years ago

I appreciate you putting together this API. I thought it would be a curiosity, but since our plumber removed -- without asking -- our external recirculation pump that was integrated with our Lutron motion sensors, it's become more important. :)

I have a stream of suggested changes. This is the first one: make clear to the user of the package what the interface is -- what they should be calling and what is internal to the package.

init.py is the interface; in this change I move everything internal out of there. There are no other changes. Let me know what you think.

explosivo22 commented 3 years ago

Thanks for this. I have started looking at this again and it falls in line with some of the ideas I had. I have more plans for it, but like the changes.