explosivo22 / rinnaicontrolr

Python interface for the Rinnai Control-R API
Apache License 2.0
12 stars 3 forks source link

Repository structure for 0.4.1 is not compliant #15

Open Dmarc2022 opened 10 months ago

Dmarc2022 commented 10 months ago

I'm relatively new to Home Assistant but with help from a friend I've been integrating devices in my home. My internet source is a T-Mobile 5G Gateway feeding a Google Mesh network. My HASS is on an old laptop (Generic x86-64) Version: 2024.1.2. My Nests, Garage door, Cameras, smart plugs all integrated without issue. It was wonderful to see this custom integration for my Rinnnai RU199iN water heater. Using HACS I attempted to "Add" the following custom repository:

https://github.com/explosivo22/rinnaicontrolr.git

repository and selected "Integration". I was presented with the error:

"<Integration explosivo22/rinnaicontrolr> Repository structure for 0.4.1 is not compliant"

My friend found this strange since he was able to Add and Integrate from the same repository just fine. After many failed attempts I took my HASS laptop to his house, on his network, and this time I too was able to Add and Integrate the same item without a problem. I returned my HASS to my network and can view my water heater without issue. Kudos to developer!

Now I'm trying to help out a future user who comes across the same error. I put a clean version of home assistant on a Raspberry PI (on my Mesh network) and reproduced the same error. I though maybe it has something to do with the Mesh router so I ran another test. Since my T-Mobile Gateway has two Ethernet jacks I put the Raspberry Pi HASS laptop in one and my computer on the other other creating a small network. Opened HA and again, I received the same error. So T-Mobile?, nah.. Can anyone suggest a fix to resolve this issue? Thanks in advance!

image
explosivo22 commented 10 months ago

Looks like you have the repository URL for using the python api. Can you try the following URL: https://github.com/explosivo22/rinnaicontrolr-ha

Dmarc2022 commented 10 months ago

Wow, that was a quick response. Definitely "coffee" worthy. :) First of all, I am still learning about HA, repositories and not really clear about the "python api" comment. However I did use your URL and was presented with the following:

image

Then I went through the following:

image image image image

So everything worked fine. However, I still don't understand why it worked with the first repository from my friends house and not mine. Are you saying he has "Python" loaded on his machine?

explosivo22 commented 10 months ago

First of all, I am still learning about HA, repositories and not really clear about the "python api" comment.

No worries at all. I too still learn new things every day. The other repository you had was for using python directly and coding something of your own. The ha one just wraps that into it so you can use it in the HA interface. Looks like you have it installed and setup correctly so hopefully no new issues arise.

So everything worked fine. However, I still don't understand why it worked with the first repository from my friends house and not mine. Are you saying he has "Python" loaded on his machine?

I am not fully sure why the other one would of worked in HA. HA has python as that is what it all runs on, but the other would be for directly writing your own code.