search

explosivo22 / rinnaicontrolr

Python interface for the Rinnai Control-R API
Apache License 2.0
12 stars 3 forks source link

push to PyPI? #7

Closed dulitz closed 3 years ago

dulitz commented 3 years ago

I think it'd be great to get this out to PyPI (even my build system pulls from there). Version 0.4 maybe? It's come a long way. :)

Not sure how PyPI works, but we now depend on "requests" and "boto3" so that needs to be described to PyPI somehow.

explosivo22 commented 3 years ago

You want to update the ReadMe or would you like me to? I will be glad to publish a release after.

dulitz commented 3 years ago

I'll craft a pull request tonight and then you can make whatever changes you want and push.

On Thu, Jul 1, 2021, 17:43 explosivo22 @.***> wrote:

You want to update the ReadMe or would you like me to? I will be glad to publish a release after.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/explosivo22/rinnaicontrolr/issues/7#issuecomment-872634800, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAVWYJIDCHUUQVFNFMZ7ZNLTVUDSJANCNFSM47VSDJFA .

explosivo22 commented 3 years ago

sounds great

dulitz commented 3 years ago

done

BTW I still don't see any changes to setup.py that establish PyPI dependencies on boto3 (as well as requests). But I'm not an expert at that, so if you know you've set that up properly please ignore me. :)

explosivo22 commented 3 years ago

Fixed some typos and checked dependencies in setup.py. Released version 0.4