search

expo-community / expo-server-sdk-python

Exponent Server SDK
MIT License
143 stars 42 forks source link

Provide message id in the return #19

Closed jliphard closed 3 years ago

jliphard commented 5 years ago

Add message ID to function return

julianpacker commented 4 years ago

When will this change get merged into master?

faridlopez commented 3 years ago

Is there an ETA for this code to be merge? or should we use our own modification? I think is good for the community to maintain this code up to date. Thanks.

julianpacker commented 3 years ago

I agree with you @faridlopez . Actually I made several changes in one the latest pull requests because I needed to make changes. Feel free to "pull" off that. I can try to get in touch with the developer and see if I can overtake ownership of this package

julianpacker commented 3 years ago

I've made this change in my pull request: https://github.com/expo-community/expo-server-sdk-python/pull/31/files. Please review if you have any concerns.

I think it's safe to close this pull request. If someone disagrees, reopen the pull request or comment here.

@faridlopez I'll be releasing a new package soon, so if you want to wait for the PyPi package, or just pull from master when I merge these pull requests in.