change requests to use Sessions, check push receipts in chunks of 1000

expo-community / expo-server-sdk-python

Exponent Server SDK

MIT License

146 stars 42 forks source link

change requests to use Sessions, check push receipts in chunks of 1000 #42

Closed julianpacker closed 3 years ago

julianpacker commented 3 years ago

As per #26 , there was an issue with getting ConnectionErrors when making multiple subsequent requests to the same url.

I'm hoping that changing to sessions could fix this. I'm testing this out currently in my production environment, if I don't see anything then I will assume this fixes the issues.

Added a couple parameters to the PushMessage as per https://docs.expo.io/push-notifications/sending-notifications/
Made push receipt checking every 1000 as per expo docs

julianpacker commented 3 years ago

Thanks for the review @benhowes. Made changes as recommended

julianpacker commented 3 years ago

Thanks @benhowes, I actually made both of these changes before, but added a docstring.

Glad you mentioned that. I'm currently testing this live with my app betstamp. Pushing it to production now and if all goes well, I'll push this change (that's how I've been testing).

benhowes commented 3 years ago

Ah, I must've been reviewing a single commit - sorry!