search

expo-community / expo-server-sdk-python

Exponent Server SDK
MIT License
146 stars 42 forks source link

Add support for multiple recipient with one push message #52

Open mbordia-eightfold opened 1 year ago

mbordia-eightfold commented 1 year ago

As per this example in expo documentation to attribute in PushMessage should expect string[] as well allowing support for multiple recipient for a push message.

There are few places in the codebase which results in the error when we pass list of expo tokens in to attribute:

  1. Expects to attribute to be string only
  2. Throws error even if response is expected response

I think proper implementation for this would either require : a. removal of the assumption that 1 push message corresponds to single recipient b. or converting single PushMessage into multiple duplicate PushMessages.

julianpacker commented 1 year ago

Good point. I never noticed that. I think doing a is the ideal solution, seems more efficient. Let me review that PR