search

expo-community / expo-server-sdk-python

Exponent Server SDK
MIT License
146 stars 42 forks source link

pip installing your sdk raises a module not found error #9

Closed seandmatthews closed 6 years ago

seandmatthews commented 6 years ago

Pip uses your setup.py file to find and install dependencies, however in your setup.py file on line 20 you import your exponent_server_sdk package which in turn imports six in it's init.py file. Pip hasn't gotten around to installing six yet, so this breaks.

I'm sure your oversight is only mildly irritating for most use cases, because you just manually install your dependencies first. If one's app sits in a docker container however, then it becomes moderately irritating to make sure that your dependencies installed before everything else because those are spun up from scratch with no manual intervention.

anp commented 6 years ago

Sorry about that! Submitted a PR internally for review.

anp commented 6 years ago

This is deployed to PyPI now, thanks for the heads up!