Returning first error message not helpful

expo-community / expo-server-sdk-ruby

A Ruby library for sending push notifications with Expo's notification service

MIT License

95 stars 53 forks source link

Returning first error message not helpful #13

Closed jonsgreen closed 2 years ago

jonsgreen commented 6 years ago

I hate to submit an issue while you are figuring out gem maintainers. However, I have to say that only showing the first error message when a bulk request fails is not helpful especially when you need to be able to parse all the failed tokens so that you can remove them from future requests. The response should ideally still accessible regardless of error so that the user can choose how to respond.

pablonahuelgomez commented 6 years ago

@jonsgreen I agree, thanks for submitting this issue. Feel free to submit a PR with a failing test, and ideally a solution for this problem.

lsmolic commented 5 years ago

Check out #29