Correctly handle error parsing for 502/503/504s and batched errors

expo-community / expo-server-sdk-ruby

A Ruby library for sending push notifications with Expo's notification service

MIT License

95 stars 53 forks source link

Correctly handle error parsing for 502/503/504s and batched errors #32

Closed jeremylightsmith closed 2 years ago

jeremylightsmith commented 4 years ago

This PR handles:

502/503/504s for which the expo server returns html, not json.
when a batch of push notifications are sent, and an item which is not the first has an error

lsmolic commented 4 years ago

@jeremylightsmith checkout #29 and see if that addresses this. I'm pretty sure by getting back all error messages, this is no longer a problem, but then again, I didn't specifically solve for those 500 level errors.