search

expo-community / expo-server-sdk-ruby

A Ruby library for sending push notifications with Expo's notification service
MIT License
95 stars 53 forks source link

Improvements / Refactoring #43

Open Aryk opened 2 years ago

Aryk commented 2 years ago

I'm not sure there is much activity on this gem.

I've been getting different errors not capable of being handled by this gem and see tons of deprecated stuff.

So I thought I would just take this gem and tear it a new one, fix a few problems and just make it easier to parse and understand.

Improvements:

  1. Added support for PUSH_TOO_MANY_EXPERIENCE_IDS (including tests) error so you'll actually see if you are getting that error.
  2. Whenever there is an unknown error, I always add the actual error message onto it so you can see what exactly failed in the code. I also pass through the details into the error message so you know what went wrong by the error message.
  3. Allow the ability to pass in options for Typheous.post so you don't have to pass in a different HTML client, so for example you can now pass in ssl_verifypeer: false to get the gem working in AWS if you are in that environment.
  4. Removed the deprecated methods.

Changes are here:

https://github.com/tribefyhq/expo-server-sdk-ruby

Maybe it's helpful for someone here.