search

expo-community / expo-server-sdk-ruby

A Ruby library for sending push notifications with Expo's notification service
MIT License
95 stars 53 forks source link

RubyGems build does match git repo #6

Closed StephenGrider closed 6 years ago

StephenGrider commented 6 years ago

Steps to Reproduce

  1. Run gem install exponent-server-sdk
  2. Navigate to your systems gem directory
  3. Open the lib/exponent-server-sdk.rb file.

Expectation Contents should match current source file here: https://github.com/expo/exponent-server-sdk-ruby/blob/master/lib/exponent-server-sdk.rb

Actual Result Contents matches the old v0.0.1 build.

Note that the gem's version.rb file correctly indicates version 0.0.2. I suspect maybe there was some git trickery at play here when someone committed changes to the exponent-server-sdk.rb file :)

pedrocarmona commented 6 years ago

@brentvatne @jesseruder could you release in rubygems?

pedrocarmona commented 6 years ago

@brentvatne @jesseruder can your release in rubygems? or make @pablonahuelgomez owner in ruby gems?

pablonahuelgomez commented 6 years ago

@ide @brentvatne @jesseruder, as @pedrocarmona is saying, I'll need ownership in rubygems to release the gem. My username there is pablonahuelgomez.

Thanks to all of you.

brentvatne commented 6 years ago

done! you're an owner now @pablonahuelgomez

pablonahuelgomez commented 6 years ago

Thanks @brentvatne. I released a new version of the gem. See: https://rubygems.org/gems/exponent-server-sdk and https://github.com/expo/exponent-server-sdk-ruby/releases.

Closing this one.