expo-community / expo-server-sdk-ruby

A Ruby library for sending push notifications with Expo's notification service
MIT License
95 stars 53 forks source link

remove encoding #9

Closed pedrocarmona closed 6 years ago

pedrocarmona commented 6 years ago

parse_json cant parse encoded response.body.

Other alternative would be to decompress gzipped response body. I opted to remove gzip deflate.

pablonahuelgomez commented 6 years ago

Hi @pedrocarmona, good catch! I agree with this. If in the future a request to accept other encodings emerges, we'll add them.

Can you please fix the failing tests? Thanks for your help

pedrocarmona commented 6 years ago

@pablonahuelgomez thanks for review, adjusted the tests

pablonahuelgomez commented 6 years ago

@pedrocarmona thanks to you. Merged.

pedrocarmona commented 6 years ago

@pablonahuelgomez could you bump version? (In my Gemfile I am pointing to master at the moment because of this)

pablonahuelgomez commented 6 years ago

Sure @pedrocarmona. Version bumped to 0.0.4

More info here: https://github.com/expo/exponent-server-sdk-ruby/releases/tag/v0.0.4

pedrocarmona commented 6 years ago

thx @pablonahuelgomez