search

expo-community / standard-version-expo

Automatic Expo versioning with Standard Version
MIT License
97 stars 29 forks source link

Update @expo/config dependency to satisfy expo doctor #45

Open GregAtFramework opened 2 years ago

GregAtFramework commented 2 years ago

Old version

The package depends on"@expo/config": ^3.1.2 which leads to the follow warning when running expo doctor (on a Expo 45 project).

Expected package @expo/config-plugins@^4.1.0
Found invalid:
  @expo/config-plugins@1.0.33

New version

No error when running expo doctor.

troZee commented 2 years ago

Please add below code to package.json as temporary workaround 

  "resolutions": {
    "standard-version-expo/**/@expo/config-plugins": "4.1.0"
  },
TowhidKashem commented 2 years ago

"standard-version-expo/**/@expo/config-plugins": "4.1.0"

I'm experiencing the same issue and this didn't work for me. I re-ran yarn install as well after adding that resolution entry but same error.

NxsHbb commented 2 years ago

I got the following while ran 'expo doctor' in SDK 45

Expected package expo-modules-autolinking@~0.8.1 || ~0.9.0 Found invalid: expo-modules-autolinking@0.5.5 (for more info, run: npm why expo-modules-autolinking) Expected package @expo/prebuild-config@^4.0.0 Found invalid: @expo/prebuild-config@3.1.2 (for more info, run: npm why @expo/prebuild-config)

gtwilliams03 commented 2 years ago

Same issue on Expo 46:

Expected package @expo/config-plugins@^5.0.0
Found invalid:
  @expo/config-plugins@1.0.33
  (for more info, run: npm why @expo/config-plugins)
josephadah commented 2 years ago

Expected package expo-modules-autolinking@~0.8.1 || ~0.9.0 Found invalid: expo-modules-autolinking@0.8.0 expo-modules-autolinking@0.7.1 (for more info, run: npm why expo-modules-autolinking) Same issue, not sure if this has anything to do with why my facebook login not working. Redirect to facebook successfully and fails to redirect back to app.

ghost commented 2 years ago

Same issue. Using expo 45 Expected package @expo/config-plugins@^4.1.0 Found invalid: @expo/config-plugins@5.0.1 (for more info, run: npm why @expo/config-plugins) Adding this to package.json (and re-installling modules) did not work: "resolutions": { "standard-version-expo/**/@expo/config-plugins": "4.1.0" },

ghost commented 2 years ago

Same issue. Using expo 45 Expected package @expo/config-plugins@^4.1.0 Found invalid: @expo/config-plugins@5.0.1 (for more info, run: npm why @expo/config-plugins) Adding this to package.json (and re-installling modules) did not work: "resolutions": { "standard-version-expo/**/@expo/config-plugins": "4.1.0" },

Upgraded to Expo 46 and removed "resolutions" from package.json. Expo doctor no longer shows any issues

andreasciamanna commented 2 years ago

I'm already in Expo 46. I even went through an expo upgrade 46 and let Expo update any package it can recognize.

The suggested workaround does not work for me.

Shouldn't @expo/config-plugins and @expo/json-file be defined as peer-dependencies?

jimmihagenTrifecta commented 2 years ago

I'm already in Expo 46. I even went through an expo upgrade 46 and let Expo update any package it can recognize.

The suggested workaround does not work for me.

Shouldn't @expo/config-plugins and @expo/json-file be defined as peer-dependencies?

Same situation here, @expo/prebuild-config, @expo/config-plugins and expo-modules-autolinking are all referenced by expo doctor, but not resolved by it.

Does this cause any issues? I have done some EAS builds that seem to work fine on device...

AdeelKahan commented 2 years ago

I create new project with Expo 46 and install some dependencies. after run expo doctor it show fix @expo/prebuild-config, @expo/config-plugins and expo-modules-autolinking these modules. I try to update those modules bit they can't update and still throw same issue. Is Expo 46 stable??

nembi-solutions commented 2 years ago

Same issue here

Expected package @expo/config-plugins@^5.0.0 Found invalid: @expo/config-plugins@3.1.0

nembi-solutions commented 2 years ago

In our case,

dan-online commented 2 years ago

I was able to fix this long ago by adding this to the package.json:

 "resolutions": {
    "@expo/config-plugins": "~5.0.1",
    "@expo/prebuild-config": "~5.0.3",
    "expo-modules-autolinking": "0.10.3"
  },
ariccio commented 1 year ago

I just tried this resolution, and it might work?

"standard-version-expo/**/@expo/config": "~7.0.2"
connorpmullins commented 1 year ago

This seems to be a real problem. This project uses two functions exposed by @expo/config in version 3, getExpoSDKVersion, and AppJSONConfig. Neither of those functions exist in major version 6 of @expo/config.

For all of you who are manually modifying the version of expo/config that gets resolved, I think you likely are breaking this package. Not in a fatal way, if it's working for you, but yeah. That seems to be what's up.

@byCedric - are there any plans to update this package?

farkerhaiku commented 1 year ago

+1 this is an issue for us after updating to expo 47. should we migrate away from this package or do you intend to update it @byCedric

adamnitti commented 1 year ago

also experiencing this issue with expo 47. still looking for a solution, thx-

kirtikapadiya commented 1 year ago

same Issue found on Expo SDK 48 unable to resolved by

I was able to fix this long ago by adding this to the package.json:

 "resolutions": {
    "@expo/config-plugins": "~5.0.1",
    "@expo/prebuild-config": "~5.0.3",
    "expo-modules-autolinking": "0.10.3"
  },
SilenceCodder commented 1 year ago

same Issue found on Expo SDK 48 unable to resolved by

I was able to fix this long ago by adding this to the package.json:

 "resolutions": {
    "@expo/config-plugins": "~5.0.1",
    "@expo/prebuild-config": "~5.0.3",
    "expo-modules-autolinking": "0.10.3"
  },

Exactly! Am try to upgrade to Expo 48, It doesn't work for me

svdwyer commented 1 year ago

this library seems abandoned, check out https://github.com/bilwifi/standard-version-expo

mccraveiro commented 1 year ago

@svdwyer that version seems abandoned as well.

mccraveiro commented 1 year ago

@svdwyer made another fork: https://github.com/mccraveiro/standard-version-expo

Witillan commented 1 year ago

"overrides" with "npm" inside the "package.json" file worked for me with Expo SDK 48

{
  "scripts": {
  },
  "dependencies": {
    "expo": "~48.0.18",
    "react": "18.2.0",
    "react-native": "0.71.8"
  },
  "overrides": {
    "expo-modules-autolinking": "~1.1.0",
    "@expo/config-plugins": "~6.0.0",
    "@expo/prebuild-config": "~6.0.0"
  }
}

Don't forget to remove the "node_modules" files and also the "package-lock.json" before "npm install"

wootwoot1234 commented 1 year ago

@byCedric can you update the packages so we don't need these work rounds?