search

expo / config-plugins

Out-of-tree Expo config plugins for packages that haven't adopted the config plugin system yet.
428 stars 91 forks source link

Add support for SDK 46 #113

Closed julste closed 1 year ago

julste commented 1 year ago

Summary

It looks like react native pdf config plugin doesn't work with SDK 46.

Config Plugin

@config-plugins/react-native-pdf

What platform(s) does this occur on?

Android, iOS

SDK Version

46

Reproducible demo

using: expo-cli doctor --fix-dependencies

results in: Expected package @expo/config-plugins@^5.0.0 Found invalid: @expo/config-plugins@4.1.5 @expo/config-plugins@4.1.5 (for more info, run: npm why @expo/config-plugins)

using: npm ls @expo/config-plugins

results in: ├─┬ @config-plugins/react-native-blob-util@0.0.0 │ └── @expo/config-plugins@4.1.5 ├─┬ @config-plugins/react-native-pdf@0.0.0 │ └── @expo/config-plugins@4.1.5

gerwim commented 1 year ago

There are multiple projects not working with SDK 46. So is @config-plugins/react-native-branch, it depends on @expo/config-plugins@"~4.1.4.

Looking at the pull requests, dependabot did a good job ;-).

kbrandwijk commented 1 year ago

Implemented in https://github.com/expo/config-plugins/pull/114